Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline the permissions policy for GitHubActionsRoleNextstrainTmpBucket #3

Merged
merged 2 commits into from
Feb 16, 2024

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Feb 16, 2024

No need to have an extra managed policy floating around when it's not used by any other principal.

Checklist

  • Checks pass

No need to have an extra managed policy floating around when it's not
used by any other principal.

I'll remove the managed policy in the subsequent commit.  Terraform
seems to require a two-step apply here to get the right ordering of
detaching the managed policy from the role and then destroying the
managed policy.
See "Inline the permissions policy for GitHubActionsRoleNextstrainTmpBucket" (166cd61).
@tsibley tsibley force-pushed the inline-tmp-bucket-policy branch from f619488 to 9e2b171 Compare February 16, 2024 19:58
@tsibley tsibley merged commit 6fd2f21 into main Feb 16, 2024
1 check passed
@tsibley tsibley deleted the inline-tmp-bucket-policy branch February 16, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant