Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add clade definitions for 24A and 24B #94

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Add clade definitions for 24A and 24B #94

merged 2 commits into from
Apr 16, 2024

Conversation

Following up on new Nextstrain clades added in
nextstrain/ncov#1103

Updated the clade colors, similar to what was done in
afbf2fb. Copied and pasted colors from
https://github.com/nextstrain/auspice/blob/cff84b3cbf13212a91c537a0b63e824682b7ebc0/src/util/globals.js#L104C3-L104C136
@joverlee521 joverlee521 marked this pull request as draft April 8, 2024 21:40
@joverlee521
Copy link
Contributor Author

Ah, right the test run completed successfully but the trial results does not include 24A/24B because they are not in the clade counts yet.

Will have to wait on the release of the new Nextclade dataset and full re-run of ncov-ingest to see these new clades come through.

@corneliusroemer
Copy link
Member

corneliusroemer commented Apr 16, 2024

There should be just a few new clade calls (not yet all as I forgot full run), enough to test, so I triggered test runs again. https://github.com/nextstrain/forecasts-ncov/actions/runs/8705257996

It's probably worth merging asap as the lack of new clades causes some issues, see Canada for example
image

@corneliusroemer corneliusroemer marked this pull request as ready for review April 16, 2024 12:42
@corneliusroemer
Copy link
Member

Coloring works - we're just waiting for the updated data
image

Use matching pivots for Nextstrain clades and Pango lineages now that
we have the new 24A clade.
@joverlee521
Copy link
Contributor Author

Force-pushed to include changes to the viz app to update the pivot clade.

Merging now since today's ncov-ingest run will be a full re-run to include the new Nextstrain clades (Slack).

@joverlee521 joverlee521 merged commit 767bbaa into main Apr 16, 2024
1 check passed
@joverlee521 joverlee521 deleted the add-24A-24B branch April 16, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants