Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ambient install docs to specify Python version #202

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

genehack
Copy link
Contributor

@genehack genehack commented Apr 30, 2024

Description of proposed changes

Updated the instructions in the ambient section to make it clear that a particular version of Python should be used. I also modified the overall intent of the instructions slightly, so that they direct the user to set up a new Conda environment. The old instructions were oriented more towards adding Nextstrain to an existing Conda enviroment, which (IMO) seems like a less common scenario, and also one more likely to be undertaken by a more experienced user who will be able to adapt these instructions on the fly; doing it this way also side-steps documenting how somebody would need to modify an existing Conda env with an unsupported version of Python.

Related issue(s)

#201

Checklist

  • Checks pass

I also modified the overall intent of the instructions slightly, so
that they direct the user to set up a new Conda environment. The old
instructions were oriented more towards adding Nextstrain to an
existing Conda enviroment, which (IMO) seems like a less common
scenario, and also one more likely to be undertaken by a more
experienced user who will be able to adapt these instructions on the
fly.
@genehack genehack requested a review from victorlin April 30, 2024 17:57
@genehack
Copy link
Contributor Author

preview

@genehack genehack changed the title Update ambiant install docs to specify Python version Update ambient install docs to specify Python version Apr 30, 2024
src/install.rst Outdated Show resolved Hide resolved
src/snippets/ambient-setup.rst Outdated Show resolved Hide resolved
src/install.rst Outdated Show resolved Hide resolved
@genehack genehack requested a review from victorlin April 30, 2024 21:16
src/snippets/ambient-setup.rst Outdated Show resolved Hide resolved
src/install.rst Outdated Show resolved Hide resolved
src/install.rst Outdated Show resolved Hide resolved
src/snippets/ambient-setup.rst Outdated Show resolved Hide resolved
@genehack genehack merged commit e026d5a into master Apr 30, 2024
4 checks passed
@genehack genehack deleted the update-req-python-version-201 branch April 30, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants