Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Nextclade v3 #204

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Use Nextclade v3 #204

merged 2 commits into from
Jan 17, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Jan 16, 2024

Description of proposed changes

Unpin Nextclade v3 alpha and use the latest version of Nextclade as default.

Any unmigrated workflows should use nextclade2 instead of nextclade. See the Nextclade v2 → v3 migration docs for details.

Related issue(s)

Checklist

  • Checks pass

@victorlin victorlin self-assigned this Jan 16, 2024
Copy link
Member

@corneliusroemer corneliusroemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM though no need to use jq here, you could just use /releases/latest/download instead of querying for the latest version
see https://docs.github.com/en/repositories/releasing-projects-on-github/linking-to-releases

Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
Previously, nextclade and nextalign both referred to the v2 CLI
commands.

Now, nextclade refers to the v3 CLI command. nextalign still refers to
the v2 CLI command because there is no Nextalign CLI in v3.¹

¹ <https://github.com/nextstrain/nextclade/releases/tag/3.0.0>
@victorlin victorlin force-pushed the victorlin/nextclade3 branch from 61a8af2 to ee302be Compare January 17, 2024 01:33
@victorlin
Copy link
Member Author

I'm signing off now so feel free to merge this before I get back to it tomorrow.

@corneliusroemer corneliusroemer merged commit 2bb5d6f into master Jan 17, 2024
33 checks passed
@corneliusroemer corneliusroemer deleted the victorlin/nextclade3 branch January 17, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants