Include Make in builder-target-platform image

[tsibley]

Required for building the Python isal package (for Augur) when there aren't wheels available (such as with recent version 1.5.2).

Checklist

• Checks pass

[tsibley]

Merging since this resolves build failures.

[victorlin]

Thanks for looking into this! Where is this isal dependency even from? I don't get it when installing Augur with pip locally.

This fragility is unfortunate, and I wouldn't be surprised if other indirect dependencies cause breakage like this in the future. Would it be worthwhile to provide a standalone installer for Augur for cases like this, where flexibility in dependency versions defined by setup.py is not necessary and even undesirable?

[joverlee521]

It's a requirement of xopen for Linux systems only. (I was curious so I tracked it down with pipdeptree in a nextstrain shell).

[tsibley]

I don't think a standalone installer for Augur is necessary for this Docker image. It'd be a bit of work for too narrow of a gain, I think, and there are other ways about it. For example, we could take additional measures in the Dockerfile to reduce this sort of breakage by using --prefer-binary to the pip install of Augur. That would have gotten us the isal 1.5.1 wheels instead of trying to build isal 1.5.2 from source. We could also maintain a constraints file and pass that in with --constraint if we wanted to pin things more tightly for this Docker image.

[victorlin]

@tsibley that makes sense. Good to know those alternatives!

[tsibley]

Two things to follow up on given discussion in pycompression/python-isal#158 (comment).

1. We should test that the python-isal builds in our arm64 image actually function as expected, as the reason wheels weren't published for 1.5.2 is not due to build failures but test failures. We're not running isal's tests at install/build time, of course. (Gosh, I miss Perl and CPAN's whole ecosystem of testing sometimes.)

2. We should expect to build python-isal going forward and not rely on wheels, at least for arm64, unless we can resolve the issues in the upstream CI which produces the wheels.