Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check installation workflow upon edit #100

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Nov 21, 2024

Description of proposed changes

This immediately verifies that the updated workflow is still valid, rather than waiting for the next scheduled run or a manual run.

Related issue(s)

Thought of this while working on #99.

Checklist

  • Installation workflow runs in PR checks (failing for unrelated reasons)
  • failure-reporting job is skipped in PR run

This immediately verifies that the updated workflow is still valid,
rather than waiting for the next scheduled run or a manual run.
@victorlin victorlin self-assigned this Nov 21, 2024
@victorlin victorlin mentioned this pull request Nov 21, 2024
3 tasks
This prevents PR runs or workflow dispatches on other branches from
opening/closing issues.
@victorlin
Copy link
Member Author

victorlin commented Nov 22, 2024

Merging this pre-review to properly test #99

@victorlin victorlin merged commit 45a83cb into main Nov 22, 2024
35 of 40 checks passed
@victorlin victorlin deleted the victorlin/installation-pr-check branch November 22, 2024 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant