standalone-installer-unix: Use new aarch64 builds for macOS #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tsibley
force-pushed
the
trs/standalone-installers/macos-aarch64
branch
from
7ea390a to
9e86268
Compare
tsibley
added a commit
to nextstrain/docs.nextstrain.org
that referenced
this pull request
Feb 1, 2024
… x.y.z Related-to: <nextstrain/cli#357> Related-to: <nextstrain/cli#358>
2 tasks
tsibley
added a commit
that referenced
this pull request
Feb 1, 2024
GitHub released public runners.¹ Great timing too, as I was just about to look into using the ARM hardware that's available for macOS with GitHub's (paid) large runners². This also beats operating a self-hosted runner, whether that's on EC2³ or our own Mac Mini.⁴ And the icing on the cake is that everything Just Worked by merely enabling builds for this architecture. \o/ High fives all around, everyone. Changes to the standalone installer to follow separately⁵, as those need to be held for merge until after the first release with these builds available. ¹ <https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source/> ² <https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1706556690621389> ³ <https://github.com/tsibley/blab-standup/blob/e7e2516fc40856a94b54eb83077d8f4bafd16914/2022-09-14.md> ⁴ <https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1670979565748349?thread_ts=1670963819.691499&cid=C01LCTT7JNN> ⁵ <#358>
tsibley
force-pushed
the
trs/standalone-installers/macos-aarch64
branch
from
9e86268 to
3ccbd10
Compare
tsibley
added a commit
that referenced
this pull request
Feb 2, 2024
When on macOS on aarch64 hardware, the Conda runtime currently requires Rosetta. The Docker runtime does not require it, but can benefit from it because our aarch64 image isn't totally free of x86_64 code (yet?), so emulation is required and Rosetta is faster than QEMU. The standalone installer still checks for Rosetta as we previously didn't produce aarch64 standalone binaries¹, but that check will be made conditional on Nextstrain CLI version in a subsequent commit² after the first release of aarch64 support and these new Rosetta checks. ¹ <#357> ² <#358>
1 task
tsibley
force-pushed
the
trs/standalone-installers/macos-aarch64
branch
from
3ccbd10 to
4ed2952
Compare
Conditions on the Nextstrain CLI version being requested, as aarch64 builds¹ will only be available going forward for new releases. Assumes the next release will be 8.2.0! Disables Rosetta check when using an aarch64 build, as the checks will be done at the runtime-level instead by `nextstrain setup` and `nextstrain check-setup`.² We must wait to merge this until after the first release (i.e. 8.2.0) of the changes it depends on above. ¹ <#357> ² <#361>
tsibley
added a commit
that referenced
this pull request
Feb 2, 2024
When on macOS on aarch64 hardware, the Conda runtime currently requires Rosetta. The Docker runtime does not require it, but can benefit from it because our aarch64 image isn't totally free of x86_64 code (yet?), so emulation is required and Rosetta is faster than QEMU. The standalone installer still checks for Rosetta as we previously didn't produce aarch64 standalone binaries¹, but that check will be made conditional on Nextstrain CLI version in a subsequent commit² after the first release of aarch64 support and these new Rosetta checks. ¹ <#357> ² <#358>
tsibley
force-pushed
the
trs/standalone-installers/macos-aarch64
branch
from
4ed2952 to
7eaaf61
Compare
tsibley
changed the title
tsibley
added a commit
to nextstrain/docs.nextstrain.org
that referenced
this pull request
Feb 2, 2024
… 8.2.0 Only the Conda runtime requires it. Related-to: <nextstrain/cli#357> Related-to: <nextstrain/cli#361> Related-to: <nextstrain/cli#358>
victorlin
approved these changes
Feb 6, 2024
tsibley
added a commit
to nextstrain/nextstrain.org
that referenced
this pull request
Feb 12, 2024
…loads
This allows URLs like:
https://nextstrain.org/cli/download/>=7.4.0/standalone-x86_64-unknown-linux-gnu.tar.gz
which will let us use the standalone installer, e.g.
curl -fsSL --proto '=https' https://nextstrain.org/cli/installer/linux | bash -s '>=7.4.0'
in automated contexts where we want to be able to declare constraints
like lower version bounds or incompatible versions.
Note that the standalone installer on macOS on aarch64 hardware does
very rudimentary version comparison¹ to decide if the requested version
is older or newer than the first release with actual aarch64 support
(8.2.0), and it won't compare version range constraints correctly:
they'll always be considered greater than (newer/later) than 8.2.0. But
I expect this to be fine in practice and not matter for actual usage.
We depend on an older version of @renovatebot/pep440 (<3) because >=3
adds a dependency on Node >=18 and this codebase is still on Node 16. I
reviewed the changelog for newer versions of the package and nothing
else substantial seems to have changed anyhow.
Related-to: <nextstrain/.github#55>
¹ <nextstrain/cli#358>
<https://github.com/nextstrain/cli/blob/af976b06/bin/standalone-installer-unix#L146-L154>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditions on the Nextstrain CLI version being requested, as aarch64 builds¹ will only be available going forward for new releases. Assumes the next release will be 8.2.0!
Disables Rosetta check when using an aarch64 build, as the checks will be done at the runtime-level instead by
nextstrain setupandnextstrain check-setup.²We must wait to merge this until after the first release (i.e. 8.2.0) of the changes it depends on above.
¹ #357
² #361
Checklist