Cattle outbreak clock filter #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help remove outliers unrelated to the cattle-outbreak, especially as the clock signal is worse than it might otherwise be for these outliers due to our enforcing of the root strain. See related discussion on slack <https://bedfordlab.slack.com/archives/CD84ELG0N/p1733773815454369>
|
Merging after comments on slack |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help remove outliers unrelated to the cattle-outbreak,
especially as the clock signal is worse than it might otherwise be for
these outliers due to our enforcing of the root strain.
Also includes some host fixes
Builds up on staging (e.g. genome) but these don't include the host fixes as I didn't run ingest locally.
P.S. These changes, were they to be implemented on top of #104, are much nicer: