Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary CI jobs #1916

Merged
merged 3 commits into from
Nov 21, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 4 additions & 20 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,20 +8,6 @@ on:
name: ci

jobs:
build:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16, 18, 20, 22]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
- run: node --version
# Build is implicit with the "prepare" life cycle script
- run: npm ci --loglevel verbose

unit-test:
runs-on: ubuntu-latest
strategy:
Expand All @@ -39,7 +25,7 @@ jobs:
- run: npm ci --loglevel verbose --ignore-scripts
- run: npm test

smoke-test:
build-and-smoke-test:
runs-on: ubuntu-latest
strategy:
matrix:
Expand All @@ -49,21 +35,19 @@ jobs:
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
# Build is implicit with the "prepare" life cycle script
- run: npm ci --loglevel verbose
- run: npm run get-data
- run: npx playwright install chromium
- run: npm run smoke-test

lint:
runs-on: ubuntu-latest
strategy:
matrix:
node: [16, 18, 20, 22]
steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node }}
node-version: 18
# Note: --ignore-scripts skips an otherwise unnecessary Auspice build, but
# also skips life cycle scripts for dependencies. If the job fails here,
# try removing this flag.
Expand Down Expand Up @@ -115,7 +99,7 @@ jobs:

publish:
if: ${{ github.ref == 'refs/heads/release' }}
needs: [build, unit-test, smoke-test, lint, check-lockfile]
needs: [build-and-smoke-test, unit-test, lint, type-check, check-lockfile]
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand Down
Loading