-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update entropy types #1915
Open
victorlin
wants to merge
10
commits into
master
Choose a base branch
from
victorlin/update-entropy-types
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update entropy types #1915
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
864707d
Use literal string values for Strand type
victorlin c22d1f8
Add whitespace between types
victorlin 4394124
Add whitespace to function signatures
victorlin 14e93af
Move comments to JSDoc
victorlin 7ac5a2b
Use interface for all object aliases
victorlin 37da370
Remove unnecessary semicolons and commas
victorlin 2d3a331
Make JsonAnnotation.strand optional
victorlin c2d10de
Add type for prevSegment
victorlin a7578d2
Update conditions for optional properties
victorlin ce1f446
Add type-safe function for n % 3
victorlin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, I find these changes kind of unfortunate (I have no doubt they are just to appease
tsc
). I'd prefer expanding out the ternary return into a longer function with more comments than additional small functions. I like the cast the best!The lack of an integer type is pretty frustrating (JS, not TS, to be fair). If the numbers supplied to this function aren't integers we've got bigger problems in Auspice than a floating point frame!