[bugfix] Restore shift-click branch behaviour #1901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking a branch while holding the shift-key should show an info modal. Bisecting indicates that this regression occurred via ``` 25294e8 is the first bad commit commit 25294e8 Author: Victor Lin <[email protected]> Date: Fri Oct 25 16:11:34 2024 -0700 Properly check window.event.shiftKey Only KeyboardEvent has the shiftKey property. src/components/tree/reactD3Interface/callbacks.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ```
nextstrain-bot
temporarily deployed
to
auspice-james-branch-sh-phuvv3
|
Merging sans review |
Man I was wrong. Should have tested this in #1864. Thanks for catching! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking a branch while holding the shift-key should show an info modal.
Bisecting indicates that this regression occurred via
(See #1900 for a somewhat related bug discovered while fixing this.)