Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent concurrent workflow runs on the same PR #1873

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

victorlin
Copy link
Member

@victorlin victorlin commented Oct 21, 2024

Description of proposed changes

The previous concurrency key mostly did this, but did not consider that the PR's ref changes when a pull request is merged. In practice, this meant that closing/merging the PR shortly shortly after updating it would trigger two workflow runs. Only the latest run (cleanup) should continue.

Related issue(s)

Follow-up to #1870 (comment)

Checklist

The previous concurrency key mostly did this, but did not consider that
the PR's ref changes when a pull request is merged. In practice, this
meant that closing/merging the PR shortly shortly after updating it
would trigger two workflow runs. Only the latest run (cleanup) should
continue.
@victorlin victorlin self-assigned this Oct 21, 2024
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-fix-p-sblq55 October 21, 2024 17:10 Inactive
@victorlin victorlin closed this Oct 21, 2024
@victorlin victorlin reopened this Oct 21, 2024
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-victorlin-fix-p-azdxte October 21, 2024 17:11 Inactive
@victorlin
Copy link
Member Author

Tested by closing this PR shortly after opening it. Concurrency works as expected:

Canceling since a higher priority waiting request for 'Preview on nextstrain.org-1873' exists

@victorlin victorlin merged commit f6a56ca into master Oct 21, 2024
53 of 56 checks passed
@victorlin victorlin deleted the victorlin/fix-preview-pr-concurrency branch October 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants