Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tree-related types #1864

Merged
merged 31 commits into from
Nov 12, 2024
Merged
Changes from 1 commit
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
c4bcae9
Compile for ES2015
victorlin Oct 25, 2024
d06d095
Fix imports from d3-scale
victorlin Oct 28, 2024
1b4c441
Remove non-existent parameter from docstring
victorlin Oct 25, 2024
cb7e657
render(): Convert from positional to named parameters
victorlin Oct 30, 2024
fd26d53
Use context-specific dispatch type
victorlin Nov 5, 2024
7b3a0e1
Add tree-related types
victorlin Nov 5, 2024
402a5e6
Add other tree-related types
victorlin Nov 5, 2024
b1b2488
tsconfig: Disable strictNullChecks
victorlin Oct 30, 2024
2e96210
Add override keyword for React lifecycle methods
victorlin Nov 5, 2024
7d22da0
Add _ prefix for unused variables
victorlin Oct 25, 2024
75fd6ad
Use exported Layout type
victorlin Nov 5, 2024
e02e0ce
Use Math.trunc instead of parseInt
victorlin Oct 25, 2024
a79226e
Use Math.min/max instead of min/max
victorlin Nov 5, 2024
5f4fe7e
Use separate variables for array and set of legend values
victorlin Oct 25, 2024
aa30581
Use null type for domRefs
victorlin Nov 5, 2024
6083f73
Properly handle unknown errors when creating color scales
victorlin Oct 25, 2024
83326a2
Properly check for stroke-width
victorlin Oct 25, 2024
25294e8
Properly check window.event.shiftKey
victorlin Oct 25, 2024
aedce7e
Properly set tipSelectedIdx
victorlin Oct 25, 2024
02b7206
Properly set timeSliceHasPotentiallyChanged
victorlin Oct 25, 2024
5b81e88
Properly set isSubtreeRoot
victorlin Oct 28, 2024
79608a5
Properly set PhyloNode.branch to [string, string]
victorlin Oct 25, 2024
9d57be8
Remove unused parameter to numDate
victorlin Oct 25, 2024
5803970
Remove unused mapLegendOpen, treeLegendOpen from controls state
victorlin Oct 29, 2024
4d2e633
Remove unused selectedNode from state
victorlin Nov 5, 2024
8c6a301
Remove unused default value for performanceFlags
victorlin Nov 7, 2024
3bd4b55
Remove broken/unused searchNodes parameter
victorlin Oct 29, 2024
56b791b
Convert RGBColor to hex string
victorlin Oct 25, 2024
5a681ff
Set default colorings in getDefaultControlsState
victorlin Oct 29, 2024
931f1e6
Set default value of focus to false
victorlin Nov 7, 2024
9c7644b
Allow setState to take a partial state
victorlin Nov 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove unused mapLegendOpen, treeLegendOpen from controls state
These were initialized with default values but unused in the code.
  • Loading branch information
victorlin committed Nov 12, 2024
commit 5803970824e36ef471084f25170f19ee34610918
4 changes: 0 additions & 4 deletions src/reducers/controls.ts
Original file line number Diff line number Diff line change
@@ -126,7 +126,6 @@ export interface BasicControlsState {
mapAnimationDurationInMilliseconds: number
mapAnimationShouldLoop: boolean
mapAnimationStartDate: unknown
mapLegendOpen?: boolean
modal: 'download' | 'linkOut' | null
normalizeFrequencies: boolean
panelLayout: string
@@ -145,7 +144,6 @@ export interface BasicControlsState {
sidebarOpen: boolean
temporalConfidence: TemporalConfidence
tipLabelKey: string | symbol
treeLegendOpen?: boolean
zoomMax?: number
zoomMin?: number
}
@@ -235,8 +233,6 @@ export const getDefaultControlsState = (): ControlsState => {
zoomMax: undefined,
branchLengthsToDisplay: "divAndDate",
sidebarOpen: initialSidebarState.sidebarOpen,
treeLegendOpen: undefined,
mapLegendOpen: undefined,
showOnlyPanels: false,
showTransmissionLines: true,
normalizeFrequencies: true,