Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always show internal node name in branch modal #1849

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Always show internal node name in branch modal #1849

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
# Changelog

* Fix bug where drag-and-drop metadata columns were no longer included as tip labels ([#1845](https://github.com/nextstrain/auspice/pull/1845))
* Fixed a bug where internal node names were sometimes omitted from the branch info modal (arrived at via shift-clicking on a branch).
They are now always displayed irrespective of the selected tip label.
([#1849](https://github.com/nextstrain/auspice/pull/1849))

## version 2.57.0 - 2024/08/30

Expand Down
2 changes: 1 addition & 1 deletion src/components/tree/infoPanels/click.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,7 @@ const NodeClickedPanel = ({selectedNode, nodesLhsTree, nodesRhsTree, clearSelect
* vs clicking on the tip (circle) itself */
const isTerminal = !node.hasChildren;
const isTip = !selectedNode.isBranch;
const shouldShowNodeName = tipLabelKey!==strainSymbol;
const shouldShowNodeName = tipLabelKey!==strainSymbol || !isTerminal;

return (
<div style={infoPanelStyles.modalContainer} onClick={() => clearSelectedNode(selectedNode)}>
Expand Down