Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom LBI color scale #1842

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Remove custom LBI color scale #1842

merged 1 commit into from
Aug 29, 2024

Conversation

huddlej
Copy link
Contributor

@huddlej huddlej commented Aug 29, 2024

Description of proposed changes

Closing an ancient TODO to remove the hardcoded color scale for LBI, since we can define custom scales now.

Example

See deployment of H3N2 HA tree colored by LBI.

Related issue(s)

Closes #805

Checklist

@nextstrain-bot nextstrain-bot temporarily deployed to auspice-remove-lbi-colo-okn9h3 August 29, 2024 17:57 Inactive
@huddlej huddlej requested a review from jameshadfield August 29, 2024 17:57
Copy link
Member

@jameshadfield jameshadfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 do you think it's worth seeing which (current core) datasets use LBI, or are you fairly confident the ones which do already define a custom scale?

Ideally we'd add a changelog entry to the PRs, although I do try to add missing stuff to the changelog immediately prior to release

@huddlej
Copy link
Contributor Author

huddlej commented Aug 29, 2024

I can add a change log note. Just checked the LBI for H3N2 HA 2y build in the deployment and it looks good. One other change that happened since 2018 is that LBI values got normalized to a max of 1, so the current auto-scale looks reasonable and generally should unless something goes terribly wrong with the LBI calculation.

@huddlej huddlej force-pushed the remove-lbi-color-scale branch from f9bc262 to da17bd5 Compare August 29, 2024 20:43
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-remove-lbi-colo-okn9h3 August 29, 2024 20:43 Inactive
@huddlej huddlej force-pushed the remove-lbi-color-scale branch from da17bd5 to e579c1e Compare August 29, 2024 20:45
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-remove-lbi-colo-okn9h3 August 29, 2024 20:46 Inactive
@huddlej huddlej merged commit e6d9b40 into master Aug 29, 2024
26 checks passed
@huddlej huddlej deleted the remove-lbi-color-scale branch August 29, 2024 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove hardcoded range for LBI
3 participants