CI: Fail on ESLint warnings #1840
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-ci-fa-pkcxs4
2 tasks
genehack
approved these changes
Aug 28, 2024
jameshadfield
approved these changes
Aug 28, 2024
Configure ESLint to fail on any number of warnings. This better surfaces warnings on PR checks. I considered putting this in the ESLint config file (.eslintrc.yaml), however it cannot be configured there and there are no plans to support that behavior¹. ¹ eslint/eslint#16804 (comment)
victorlin
force-pushed
the
victorlin/ci-fail-on-lint-warnings
branch
from
add2778 to
81bee2f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Configure ESLint to fail on any number of warnings. This better surfaces warnings on PR checks.
I considered putting this in the ESLint config file (.eslintrc.yaml), however it cannot be configured there and there are no plans to support that behavior¹.
¹ eslint/eslint#16804 (comment)
Related issue(s)
Closes #1839
Checklist
If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PRN/A(to be done by a Nextstrain team member) Create preview PRs on downstream repositories.N/A