Tangletree genotype colouring #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This property will be used in upcoming work to show genotype colourings on both trees
jameshadfield
force-pushed
the
james/tangletree-genotype-colouring
branch
from
e120c86 to
de5ab6e
Compare
This particular method of loading a second tree is (I believe) rarely used and rarely developed -- see both the TODOs in the surrounding code and the (dev-only) redux immutability errors fixed in this commit. Still, we should support it!
In preparation for showing genotype colorings across multiple trees We don't (yet) consider root-sequences which are defined via sidecar files (i.e. not inline in the main JSON) We could improve memory efficiency if we compared the nuc/aa sequences for equality and used references to the main tree's root-sequence data, but as we're here only considering inlined root-sequences (i.e. small ones!) this implementation is simpler.
jameshadfield
force-pushed
the
james/tangletree-genotype-colouring
branch
from
de5ab6e to
8324f8a
Compare
genehack
approved these changes
Jun 10, 2024
Includes some (overly!) strict conditionals. This functionality is particularly useful when comparing trees using the same (or very similar) sequences / sets of sequences to aid in understanding the different tree structures. Closes #1773
Oh how TypeScript would have helped! This bug was found while debugging the ability to show genotype colorings on both trees (added in the parent commit) where the visibility of the second tree was `undefined` upon loading, leading to `createVisibleLegendValues` not considering the second tree and thus removing legend items which were only observed in the second tree. Bug introduced ~4 years ago via 391bca4 although its effect was minor (and probably never noticed?)
jameshadfield
force-pushed
the
james/tangletree-genotype-colouring
branch
from
8324f8a to
a87c595
Compare
genehack
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages for details.
Closes #1773