Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node-selection issues in RHS trees #1783

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Conversation

jameshadfield
Copy link
Member

@jameshadfield jameshadfield commented Jun 6, 2024

See commit messages for details

  • Checks pass
  • If making user-facing changes, add a message in CHANGELOG.md summarizing the changes in this PR

Fixes a bug whereby branch hover/click-events didn't work because the
tip label captured the mouse, which is very common on tangletrees
(because the text starts to the right of the tip and thus always
obscures branches). Note that the branch labels already had this setting.
This bug arrived with recent work which lifted the selected node state
out of component state and into redux¹, where I forgot to consider
tangletrees so that we always ended up retrieving the node (via array
index) from the LHS tree.

Closes <#1770>

¹ <#1749>
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-james-tangle-17-pdiiiv June 10, 2024 00:04 Inactive
@jameshadfield jameshadfield merged commit b68707f into master Jun 10, 2024
20 checks passed
@jameshadfield jameshadfield deleted the james/tangle-1770 branch June 10, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants