Nextclade linkout #1776
Merged
Nextclade linkout #1776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new design co-locates the data with the rendering, which is an anti-pattern but in this case it allows for each link-out to have much more flexibility in how it constructs the data. The co-location is necessary for the function (component) to access `useSelector`, with the inherent flexibility that provides. The trade-off is worth it in my opinion.
jameshadfield
commented
Jun 5, 2024
Most discussion about this functionality has been happening within the nextclade repo, see <nextstrain/nextclade#1455> and <nextstrain/nextclade#1460> for a good summary.
jameshadfield
force-pushed
the
james/nextclade-linkout
branch
from
ca00d23 to
e526494
Compare
|
Merging after testing in the nextstrain.org review app |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most discussion about this functionality has been happening within the nextclade repo, see nextstrain/nextclade#1455 and nextstrain/nextclade#1460 for a good summary.
Testing
via nextstrain.org review app, e.g. https://nextstrain-s-nextstrain-ytpxv6.herokuapp.com/avian-flu/h5n1-cattle-outbreak/genome then click the button in the footer "view in other platforms"