[preview 4] Redesign panel sections in sidebar #1721
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The component was written to allow tooltip as optional, so make that explicit. Other props should be required.
This keeps the styling closer to where it is used.
Previously, it looked like language was a part of Panel Options.
Instead of determining in the sidebar and passing down as props.
Disabling this makes typed prop drilling more readable by not requiring a conditional for optional props¹. ¹ https://stackoverflow.com/a/48816255
Split AnnotatedHeader into AnnotatedTitle and ControlHeader. A future commit will introduce PanelHeader. This places the header info icon immediately to the right of the title, instead of the far right side (to make room for the upcoming panel visibility toggle).
Do this with some new panel-specific components that build upon the existing AnnotatedTitle and Toggle components. Simplify headers and translations to just the panel name (e.g. Tree) instead of "Show <panel name>" / "<panel name> Options". Conditionally render the entire "Panel Options" section including the header. This also adds a section for the entropy panel to maintain its toggle-ability. This is an empty section because it does not have any sidebar options.
This color is now used for more than just the unselected background.
nextstrain-bot
temporarily deployed
to
auspice-victorlin-move--smhs4h
I chose the title "Display" even though it is called "layout" in the state because "Layout" is already used to describe tree layout, and I didn't want translations to conflict. I also contemplated putting this control at the top. However, its conditional rendering worsens usability upon toggling panel visibility, as the scroll position is changed due to its placement above the toggles.
victorlin
force-pushed
the
victorlin/move-panel-toggles-preview4
branch
from
e3eabae to
8a69ca2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prototyping for #1704. For preview purposes only. Do not merge.