Add node.js v20 support #1673
Add node.js v20 support #1673
Conversation
jameshadfield
force-pushed
the
engine-updates
branch
from
c11e238 to
9bfac09
Compare
| @@ -12,7 +12,7 @@ jobs: | |||
| runs-on: ubuntu-latest | |||
| strategy: | |||
| matrix: | |||
| node: [14, 16, 18] | |||
There was a problem hiding this comment.
The Docker image still uses Node.js 14 for installing/using Auspice. There is a PR to use Node.js 16 but it hasn't been pushed through since it's based on a bigger change.
There was a problem hiding this comment.
Do you have a timeline for those changes to the docker image? I can update this PR and #1672 to remain compatible to node14 for the time being, if needs be.
There was a problem hiding this comment.
Yes, let's keep Node.js 14 support until this is done. It's mostly dependent on nextstrain/docker-base#98, so I'll push on that a bit harder now and update here when it's done.
v20 is the current version, with scheduled end-of-life 2026-04-30¹. The associated npm version (as of node v20.3.0) is still npm v9². ¹ https://github.com/nodejs/release#release-schedule ² https://nodejs.org/dist/index.json
jameshadfield
force-pushed
the
engine-updates
branch
from
9bfac09 to
e9b19e6
Compare
There was a problem hiding this comment.
Can bundlesize be updated to use 20 as well?
There was a problem hiding this comment.
Probably, but f we had to pick one node version I'd pick the one we use to publish auspice (v18)
There was a problem hiding this comment.
Oh, I didn't notice there are other jobs that also use v18. Yes, those should be updated together later.
See commit messages for details