dev: Update workflow which creates PRs for nextstrain.org to account for Auspice move there #1661
Conversation
…for Auspice move there Related-to: <nextstrain/nextstrain.org#673>
…tions Avoids bringing in all of Auspice's deps into the server code. This is generally useful, but it was also specifically useful in recent prototyping to allow use of React 18 server components (as Auspice requires React 16). In any case, I think organizationally this makes more sense anyway. Related-to: <nextstrain/auspice#1661>
…tions Avoids bringing in all of Auspice's deps into the server code. This is generally useful, but it was also specifically useful in recent prototyping to allow use of React 18 server components (as Auspice requires React 16). In any case, I think organizationally this makes more sense anyway. Related-to: <nextstrain/auspice#1661>
…tions Avoids bringing in all of Auspice's deps into the server code. This is generally useful, but it was also specifically useful in recent prototyping to allow use of React 18 server components (as Auspice requires React 16). In any case, I think organizationally this makes more sense anyway. Related-to: <nextstrain/auspice#1661>
…tions Avoids bringing in all of Auspice's deps into the server code. This is generally useful, but it was also specifically useful in recent prototyping to allow use of React 18 server components (as Auspice requires React 16). In any case, I think organizationally this makes more sense anyway. Related-to: <nextstrain/auspice#1661>
|
I started a test run for this PR and it worked (producing nextstrain/nextstrain.org#674), but took 15 minutes to |
|
Looks like it:
Jeez. I guess it's fine though. |
|
@tsibley yeah, I noticed this a while back. I did some digging and this GitHub issue was the most informative: npm/cli#4896 Looks like we're still using Node.js 14 / NPM 6 in the workflow. I'll make a PR to update it, since both downstream repos are using later versions now, and that should improve speed here based on the comments in the linked issue. |
|
@victorlin Ah, excellent! I did notice that the CI logs warn about using NPM 6 when Auspice declares compat with, at minimum, NPM 7. But it still proceeded and worked, so… |
Related-to: nextstrain/nextstrain.org#673
Testing