-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URL query for show all (branch) labels #1575
Conversation
Tested manually & via /narratives/test/simultaneous-tree-updates Closes #1573
5ceac80
to
b803c7b
Compare
I've not added this to the dataset defaults (of the dataset JSON) because there's currently not an obvious place to put it. We would want it to be settable per-branch-label, so something like: display_defaults: {
branch_label: "aa", // already exists
show_all_branch_labels: ["clade"], // one option, but locks us into "all"
show_branch_labels: {clade: "all"} // keeps the door option to future options?
} (There's also the related-but-separate desire to be able to set branch label titles.) |
The review-app appears to have been build ("-----> Launching... Released v5. https://auspice-feat-branch-lab-hdcfc5.herokuapp.com/ deployed to Heroku") however I see the following when loading that URL. I don't think this 🐛 is the fault of this PR however |
Huh, the review app works for me now. There must have been something weird on Heroku's side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I pushed up commits to update the docs for URL params.
Thanks @joverlee521! |
Tested manually & via /narratives/test/simultaneous-tree-updates
Closes #1573