Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL query for show all (branch) labels #1575

Merged
merged 3 commits into from
Oct 20, 2022

Conversation

jameshadfield
Copy link
Member

Tested manually & via /narratives/test/simultaneous-tree-updates

Closes #1573

@nextstrain-bot nextstrain-bot temporarily deployed to auspice-feat-branch-lab-hdcfc5 October 20, 2022 01:55 Inactive
Tested manually & via /narratives/test/simultaneous-tree-updates

Closes #1573
@jameshadfield jameshadfield force-pushed the feat/branch-label-toggle-url-query branch from 5ceac80 to b803c7b Compare October 20, 2022 02:01
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-feat-branch-lab-hdcfc5 October 20, 2022 02:01 Inactive
@jameshadfield
Copy link
Member Author

I've not added this to the dataset defaults (of the dataset JSON) because there's currently not an obvious place to put it. We would want it to be settable per-branch-label, so something like:

display_defaults: {
  branch_label: "aa", // already exists
  show_all_branch_labels: ["clade"], // one option, but locks us into "all"
  show_branch_labels: {clade: "all"} // keeps the door option to future options?
}

(There's also the related-but-separate desire to be able to set branch label titles.)

@jameshadfield
Copy link
Member Author

The review-app appears to have been build ("-----> Launching... Released v5. https://auspice-feat-branch-lab-hdcfc5.herokuapp.com/ deployed to Heroku") however I see the following when loading that URL. I don't think this 🐛 is the fault of this PR however
image

@joverlee521
Copy link
Contributor

joverlee521 commented Oct 20, 2022

Huh, the review app works for me now. There must have been something weird on Heroku's side.
(EDIT: I spoke too soon. The splash page loads now, but I still can't access individual datasets)
(EDIT2: After hard refreshing the page 5 times, the dataset loads now 😅 )

@nextstrain-bot nextstrain-bot temporarily deployed to auspice-feat-branch-lab-hdcfc5 October 20, 2022 21:09 Inactive
Copy link
Contributor

@joverlee521 joverlee521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I pushed up commits to update the docs for URL params.

@jameshadfield
Copy link
Member Author

Thanks @joverlee521!

@jameshadfield jameshadfield merged commit 8aa25f7 into master Oct 20, 2022
@jameshadfield jameshadfield deleted the feat/branch-label-toggle-url-query branch October 20, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ENH: Make more view settings a URL parameter for more reproducible views
3 participants