Merge pull request #1849 from nextstrain/james/internal-node-name-dis…

…play Always show internal node name in branch modal
nextstrain · Sep 11, 2024 · 30c60db · 30c60db
2 parents 6ef1fe7 + 04a5052
commit 30c60db
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,6 +1,9 @@
 # Changelog
 
 * Fix bug where drag-and-drop metadata columns were no longer included as tip labels ([#1845](https://github.com/nextstrain/auspice/pull/1845))
+* Fixed a bug where internal node names were sometimes omitted from the branch info modal (arrived at via shift-clicking on a branch).
+  They are now always displayed irrespective of the selected tip label.
+  ([#1849](https://github.com/nextstrain/auspice/pull/1849))
 
 ## version 2.57.0 - 2024/08/30
 

diff --git a/src/components/tree/infoPanels/click.js b/src/components/tree/infoPanels/click.js
@@ -259,7 +259,7 @@ const NodeClickedPanel = ({selectedNode, nodesLhsTree, nodesRhsTree, clearSelect
    * vs clicking on the tip (circle) itself */
   const isTerminal = !node.hasChildren;
   const isTip = !selectedNode.isBranch;
-  const shouldShowNodeName = tipLabelKey!==strainSymbol;
+  const shouldShowNodeName = tipLabelKey!==strainSymbol || !isTerminal;
 
   return (
     <div style={infoPanelStyles.modalContainer} onClick={() => clearSelectedNode(selectedNode)}>