Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump auspice from 2.39.0 to 2.40.0 #39

Merged
merged 1 commit into from
Oct 23, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 21, 2022

Bumps auspice from 2.39.0 to 2.40.0.

Release notes

Sourced from auspice's releases.

Auspice 2.40.0

  • Keep the measurements panel's color-by means in a stable order while filtering. See [PR #1566](nextstrain/auspice#1566) for more.
  • Allow setting the "show all branch labels" toggle via the URL query ?showBranchLabels=all. See [PR #1575](nextstrain/auspice#1575) for more.
  • Fix a bug where ordinal scales wouldn't be colored correctly in the frequency pane. See [Issue #843](nextstrain/auspice#843) and [PR #1578](nextstrain/auspice#1578) for more.
  • The legend can no longer have duplicate entries (both for user provided color scales and for continuous scales), which also prevents the display bug where legend items may be overlapping when switching to a different coloring. See issues #1521 and #1547, and PR 1576.
  • Re-enable temporal confidence bars for trees which include this data. See [PR #1577](nextstrain/auspice#1577) for more.
Changelog

Sourced from auspice's changelog.

version 2.40.0 - 2022/10/21

  • Keep the measurements panel's color-by means in a stable order while filtering. See [PR #1566](nextstrain/auspice#1566) for more.
  • Allow setting the "show all branch labels" toggle via the URL query ?showBranchLabels=all. See [PR #1575](nextstrain/auspice#1575) for more.
  • Fix a bug where ordinal scales wouldn't be colored correctly in the frequency pane. See [Issue #843](nextstrain/auspice#843) and [PR #1578](nextstrain/auspice#1578) for more.
  • The legend can no longer have duplicate entries (both for user provided color scales and for continuous scales), which also prevents the display bug where legend items may be overlapping when switching to a different coloring. See issues #1521 and #1547, and PR 1576.
  • Re-enable temporal confidence bars for trees which include this data. See [PR #1577](nextstrain/auspice#1577) for more.
Commits
  • 9500826 version bump to 2.40.0 for release
  • 7ecd4dd changelog
  • 6b31ab7 Merge pull request #1577 from nextstrain/bug/date-confidence
  • 8a1411d Merge pull request #1576 from nextstrain/bug/overlapping-legend-text
  • 9b6114b Merge pull request #1578 from nextstrain/bug/ordinal-scale-frequency-colors
  • 8f80505 Filter identical legend values
  • 4a01ce2 Handle user color scales with duplicate entries
  • b8f36f0 Fix overlappping legend entries
  • d324887 Fix frequency colors for ordinal scales
  • 8aa25f7 Merge pull request #1575 from nextstrain/feat/branch-label-toggle-url-query
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 21, 2022
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-us-dependabot-n-hap37n October 21, 2022 01:42 Inactive
@jameshadfield
Copy link
Member

jameshadfield commented Oct 21, 2022

This failed to build on heroku:

       Downloading and installing node 18.11.0...
       Using default npm version: 8.19.2
...
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'

Which I think is fixed by setting export NODE_OPTIONS=--openssl-legacy-provider if you are using nodejs 17 and 18 (I think those versions are correct, haven't double checked).

Auspice.us doesn't specify a node version in its package.json and we're using the heroku-22 stack. The heroku docs state "If a Node version isn’t specified in the engine, the 18.x release will be used on Heroku-20 or newer" so I wonder if this is a recent change (i.e. it used to be nodejs 16) and so we could either (a) need to set a config var in heroku or (b) specify nodejs=16 in our package.json, or (c) specify nodejs=18 and change the packag.json scripts to set that variable each time?

cc @victorlin

@victorlin
Copy link
Member

Oh, yes it's a good idea to set the Node.js version in package.json (even Heroku says so).

This must have been a recent change, since the build log for the currently deployed auspice.us instance (2 days ago) shows:

-----> Building on the Heroku-22 stack
-----> Using buildpack: heroku/nodejs
-----> Node.js app detected

...

-----> Installing binaries
       engines.node (package.json):  unspecified
       engines.npm (package.json):   unspecified (use default)
       
       Resolving node version 16.x...
       Downloading and installing node 16.18.0...
       Using default npm version: 8.19.2

I've created a PR to set version 16: #40. Will merge once I confirm it works, then dependabot should automatically rebase this PR.

Bumps [auspice](https://github.com/nextstrain/auspice) from 2.39.0 to 2.40.0.
- [Release notes](https://github.com/nextstrain/auspice/releases)
- [Changelog](https://github.com/nextstrain/auspice/blob/master/CHANGELOG.md)
- [Commits](nextstrain/auspice@v2.39.0...v2.40.0)

---
updated-dependencies:
- dependency-name: auspice
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/auspice-2.40.0 branch from 5f4cb88 to 55c1f37 Compare October 21, 2022 18:22
@nextstrain-bot nextstrain-bot temporarily deployed to auspice-us-dependabot-n-zyh7dm October 21, 2022 18:23 Inactive
@jameshadfield
Copy link
Member

Nice one @victorlin! Review app builds correctly so I'm going to merge this

@jameshadfield jameshadfield merged commit 427c138 into master Oct 23, 2022
@jameshadfield jameshadfield deleted the dependabot/npm_and_yarn/auspice-2.40.0 branch October 23, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants