Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File picker on splash page #25

Closed
jameshadfield opened this issue Mar 10, 2022 · 3 comments
Closed

File picker on splash page #25

jameshadfield opened this issue Mar 10, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@jameshadfield
Copy link
Member

Context

The current drag-and-drop interface is limiting for a number of reasons, and was primarily implemented due to simplicity. It enforces that all files are dragged on at the same time (except those files which shouldn't be, such as metadata CSVs!), and with the implementation of narratives/sidecar files in #23 there is no way to order the datasets for tangletrees. Furthermore, some users are more familiar with a "select file(s)" interfaces. Nextclade has a nice simple example of such as UI.

Description

The following functionality is desirable, but a MVP could implement only a subset:

  • Ability to select files
  • Ability to drag on files in different stages
  • Automatic grouping of dragged files into "datasets" (i.e. X.json and X_measurements.json are grouped). I'll use the term "slot" for this below.
    • This should highlight orphaned files (e.g. X_measurements.json where X.json wasn't dropped on).
    • Bonus: some sidecars require that an entry is present in meta.panels. We should indicate when this is not the case, as the sidecar won't load.
  • Auspice can only display two datasets. Using the slots described above, we should indicate that slots 3 onwards will not be displayed
    • Order is important (think tangletrees) so we should allow slots to be reordered.
    • The second slot (tree) won't use tip-frequencies / measurements panels, and possibly not the root-sequence. The UI would want to indicate that these sidecar files, if present, will be unused.
  • For narratives, one option would be to create a set of (possibly) empty slots for each URL path specified in the markdown.
    • I think it's reasonable to not allow a narrative to load without each slot having a dataset loaded.
    • We could think about allowing dataset names to not match the URLs so precisely, but here be 🐲
    • Multiple narratives don't make sense for auspice.us
  • Metadata CSVs currently have to be dropped on. It'd be nice to allow them to be used here, but not essential and complicated (requires digging more into auspice's internals I imagine).
@corneliusroemer
Copy link
Member

Just came here to request this :) Wanted to load a tree on mobile where I can't drop

@victorlin victorlin self-assigned this Dec 15, 2023
@victorlin
Copy link
Member

victorlin commented Dec 27, 2023

I created #77 which simply adds a file picker on the splash page. This doesn't address most of the features in the issue description, which are more about generally handling other file loading scenarios that extend beyond initial load from the splash page.

@victorlin
Copy link
Member

Closing this since there is a file picker now. Feel free to re-open or create separate issues for the other features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
No open projects
Status: Prioritized
Development

No branches or pull requests

3 participants