Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved error messages for narratives #60

Closed
jameshadfield opened this issue Jun 12, 2023 · 2 comments
Closed

Improved error messages for narratives #60

jameshadfield opened this issue Jun 12, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@jameshadfield
Copy link
Member

Current Behavior

Dropping narratives (with or without associated datasets) onto auspice.us doesn't work - error notification "auspice.us couldn't load any of the dropped files!". Example console message:

Read flu_seasonal_h3n2_ha_2y.json as a main dataset JSON file
Read test_simultaneous-tree-updates.md as a narrative.
Linking narrative datasets to dropped JSON datasets.
Narrative slide URL flu/seasonal/h3n2/ha/3y expected flu_seasonal_h3n2_ha_3y.json but this wasn't found.

Behavior exists at auspice.us 0.12.0 (Auspice 2.46.0) and is unchanged in #59, so I'm going to merge that now.

@joverlee521
Copy link
Contributor

I thought for auspice.us, you must include a dataset JSON with the narratives?

* A narrative (markdown) can be loaded, as long as they are dragged together with the datasets they reference.


Hmm, I cannot replicate the bug when dropping narratives with associated datasets.
Based on the example console message, it seems like you had a 2y vs 3y mismatch in the dataset name.

@jameshadfield jameshadfield changed the title Narratives broken Improved error messages for narratives Jun 13, 2023
@jameshadfield
Copy link
Member Author

🤦 thanks @joverlee521

#25 should be able to improve this experience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants