-
Notifications
You must be signed in to change notification settings - Fork 128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Update pathogen-repo-ci #1549
Conversation
Add comments to clearly show the job `pathogen-repo-ci-v0` is for pathogen repos that do not conform to the standard pathogen repo structure. Since these are tied to an old structure of pathogen repos, the job should not be expected to be updated. Any new pathogen repos should be added to the `pathogen-repo-ci` job which replicates the centralized `pathogen-repo-ci` GH workflow. Replicating the centralized `pathogen-repo-ci` because we've made the decision to _not_ support ambient Augur version¹ ¹ <nextstrain/.github#66>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpicky & ignorable
I would maybe put the version we intend most things to use above the legacy version that we don't want new things to use; otherwise LGTM
As per @victorlin 's recommendation in related change in conda-base,¹ these pathogens can get updated as post-merge tasks for eventual PRs. ¹ <nextstrain/conda-base#85 (comment)>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1549 +/- ##
==========================================
+ Coverage 70.09% 70.13% +0.03%
==========================================
Files 74 74
Lines 7922 7922
Branches 1938 1938
==========================================
+ Hits 5553 5556 +3
+ Misses 2085 2081 -4
- Partials 284 285 +1 ☔ View full report in Codecov by Sentry. |
Move the latest pathogen-repo-ci above legacy version as per @genehack's recommendation in review <#1549 (review)>
Description of proposed changes
Add comments to clearly show the job
pathogen-repo-ci-v0
is for pathogen repos that do not conform to the standard pathogen repo structure. Since these are tied to an old structure of pathogen repos, the job should not be expected to be updated.Any new pathogen repos should be added to the
pathogen-repo-ci
job which replicates the centralizedpathogen-repo-ci
GH workflow. Replicating the centralizedpathogen-repo-ci
because we've made the decision to not support ambient Augur version¹¹ nextstrain/.github#66
Related issue(s)
Related to nextstrain/.github#84
Checklist