Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable monkeypox CI until pathogen-repo-ci supports custom build directories See issue https://github.com/nextstrain/.github/issues/63 #1324

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

corneliusroemer
Copy link
Member

Disable monkeypox CI until pathogen-repo-ci supports custom build directories

See issue nextstrain/.github#63

Fixes augur CI failures

Copy link
Member

@victorlin victorlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(copied from Slack)

I don't think disabling monkeypox CI (not only necessary now in Augur, but also docker-base, conda-base) is an acceptable trade-off to use the new pathogen template. I'd vote to revert nextstrain/mpox#198 until pathogen-repo-ci is updated to work with the new template.

@corneliusroemer corneliusroemer merged commit 5aba7ec into master Sep 27, 2023
23 checks passed
@corneliusroemer corneliusroemer deleted the disable-monkeypox-ci branch September 27, 2023 14:39
@joverlee521
Copy link
Contributor

I just remembered that this CI workflow is actually not even using the pathogen-repo-ci because we are testing the local version of Augur

# TODO: Use the central pathogen-repo-ci workflow¹. Currently, this is not
# possible because it only supports "stock" docker and conda runtimes.
# ¹ https://github.com/nextstrain/.github/blob/-/.github/workflows/pathogen-repo-ci.yaml

Leaving as-is for now as we figure out the standard repo organization and decide if we want to make sweeping changes, but we should resolve nextstrain/.github#66 so that we don't have to maintain this CI workflow separately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants