Address pkg_resources deprecation warnings #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
(from my comment in Slack) The package resources stuff is a mess currently in Python. There's been a lot of churn. One downside to the solution here is that the file is completely loaded into memory at least three times (pkgutil, StringIO, our eventual parsing of it). Using the newest |
victorlin
force-pushed
the
victorlin/replace-pkg_resources
branch
from
05cbec5 to
32af1e8
Compare
victorlin
commented
Jul 11, 2023
tsibley
requested changes
Jul 18, 2023
Closed
victorlin
force-pushed
the
victorlin/replace-pkg_resources
branch
from
32af1e8 to
29950aa
Compare
There are several alternatives¹. Only one (importlib.resources.as_file + open) avoids reading the entire file into memory by using a temporary file on disk. ¹ https://stackoverflow.com/a/58941536
Use an approach similar to the previous commit.
packaging.version.Version is the official replacement¹. ¹ https://packaging.pypa.io/en/latest/version.html#packaging.version.Version
victorlin
force-pushed
the
victorlin/replace-pkg_resources
branch
from
29950aa to
2b58409
Compare
tsibley
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Previously, some warnings were visible upon running pytest.
Related issue(s)
N/A, I came across this while looking at CI logs.
Testing
devel/releaseare covered by tests)Checklist
Add a message in CHANGES.md summarizing the changes in this PR that are end user focused. Keep headers and formatting consistent with the rest of the file.N/A, no functional changes