Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support numpy major version 2 #1504

Open
corneliusroemer opened this issue Jun 29, 2024 · 1 comment · May be fixed by #1533
Open

Support numpy major version 2 #1504

corneliusroemer opened this issue Jun 29, 2024 · 1 comment · May be fixed by #1533
Labels
enhancement New feature or request

Comments

@corneliusroemer
Copy link
Member

Numpy has recently released version 2: https://numpy.org/doc/stable/release/2.0.0-notes.html

We currently pin numpy to <2:

augur/setup.py

Line 62 in 1694a3f

"numpy ==1.*",

See nextstrain/public#12 for a similar issue about pandas v2
@corneliusroemer corneliusroemer added the enhancement New feature or request label Jun 29, 2024
@corneliusroemer corneliusroemer linked a pull request Jul 11, 2024 that will close this issue
Draft
4 tasks
@victorlin victorlin mentioned this issue Jul 11, 2024
Open
6 tasks
@corneliusroemer
Copy link
Member Author

Only pandas v2.2.something is compatible with numpy v2, will be interesting to see whether this means we need to drop pandas v1 support. We shouldn't really have to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): allow numpy v2 nextstrain/augur
1 participant
@corneliusroemer