Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pinned dependencies #1535

Open
3 of 6 tasks
victorlin opened this issue Jul 11, 2024 · 2 comments
Open
3 of 6 tasks

Update pinned dependencies #1535

victorlin opened this issue Jul 11, 2024 · 2 comments

Comments

@victorlin
Copy link
Member

victorlin commented Jul 11, 2024

Dependencies are pinned to reduce the need for urgent code compatibility updates on every breaking change from a dependency. We should still be keeping the code compatible with latest versions of dependencies, just at our own pace. Otherwise Augur will become hard to install in environments where users prefer to use latest versions of these dependencies.

This issue aims to go through the list once, but this should be done regularly.

Tasks

References

@corneliusroemer
Copy link
Member

We could potentially look into dependabot for pip, but first we'd have to migrate away from setup.py towards pyproject.toml - maybe not a bad idea for the long run, but I don't know what side effects/downsides there might be.

https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#pip-and-pip-compile

setup.py is not supported by dependabot.

@corneliusroemer
Copy link
Member

corneliusroemer commented Jul 11, 2024

Actually I might be wrong - setup.py is potentially supported: https://github.com/nextstrain/augur/network/dependencies

From simonw: https://til.simonwillison.net/github/dependabot-python-setup

The Dependabot setup instructions don't explicitly mention projects which keep all of their dependency information in setup.py.

It works just fine with those kinds of projects too.

To start it working, create a file in .github/dependabot.yml with the following contents:

version: 2
updates:
- package-ecosystem: pip
  directory: "/"
  schedule:
    interval: daily
    time: "13:00"
  groups:
    python-packages:
      patterns:
        - "*"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants