Nested pathogen-repo-ci #65
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is done in prepartion for consolidating the pathogen-repo-ci and pathogen-repo-build workflows by having the pathogen-repo-ci calling the pathogen-repo-build. Creating this commit first because the pathogen-repo-ci will need to hardcode the sha for this version of the pathogen-repo-build.
This allows the pathogen-repo-ci to continue to manage the complexity related to testing multiple runtimes, but surfaces the flexibility of the pathogen-repo-build inputs. There are two major downsides to this approach: 1. We must hardcode the ref used for the pathogen-repo-build. We cannot get around this with the workflow-context action because this is calling a resuable workflow as a full job rather than an action step within a job. 2. We have to define additional permissions from the caller for both the pathogen-repo-ci and the pathogen-repo-build with these updates because if you specify the access for any of the scopes, all of those that are not specified are set to none.
Add the permissions for the pathogen-repo-ci and pathogen-repo-build workflows that are now required due to the consolidation of the two workflows.
|
Based on Jover's original description of the drawbacks with this approach and the lack of further movement in the ~6 months since, I think this is closable? |
|
Thanks for flagging @genehack! This is probably not the direction we'll be taking with pathogen CIs, so closing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Consolidates the pathogen-repo-ci and the pathogen-repo-build by having pathogen-repo-ci call on pathogen-repo-build. Suggested by @tsibley in #62 (comment).
Technically the nested workflow is doable and it works (at least in this repo's CI job), but I'm not a big fan of the downsides of this approach.
There are two major downsides:
We must hardcode the ref used for the pathogen-repo-build. We cannot
get around this with the workflow-context action because this is calling
a resuable workflow as a full job rather than an action step within a job.
We have to define additional permissions from the caller for both
the pathogen-repo-ci and the pathogen-repo-build with these updates
because if you specify the access for any of the scopes, all of those
that are not specified are set to none.
Checklist