Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nextest-runner] make Windows job object termination clearer #1990

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

sunshowers
Copy link
Member

In case of a Ctrl-C grace period expiring, we should make it clear to users what's happening rather than just printing out "FAIL".

@sunshowers sunshowers force-pushed the clear-job-object branch 7 times, most recently from fcddf22 to 268c586 Compare December 17, 2024 21:42
In case of a Ctrl-C grace period expiring, we should make it clear to users
what's happening rather than just printing out "FAIL".

Also make a slight formatting tweak.
Copy link

trunk-io bot commented Dec 17, 2024

Static BadgeStatic BadgeStatic BadgeStatic Badge

Failed Test Failure Summary Logs
reporter::aggregator::junit::tests::test_set_execute_status_props The test failed due to a process being aborted with signal 15 (SIGTERM). Logs ↗︎
reporter::aggregator::junit::tests::test_set_execute_status_props The test failed due to a process being aborted with signal 15 (SIGTERM). Logs ↗︎

View Full Report ↗︎Docs

@sunshowers sunshowers merged commit e31b835 into main Dec 17, 2024
17 checks passed
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 60 lines in your changes missing coverage. Please review.

Project coverage is 80.60%. Comparing base (c612aea) to head (d3fe12a).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
nextest-runner/src/runner/unix.rs 32.89% 51 Missing ⚠️
nextest-runner/src/runner/executor.rs 0.00% 5 Missing ⚠️
nextest-runner/src/helpers.rs 20.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1990      +/-   ##
==========================================
+ Coverage   80.59%   80.60%   +0.01%     
==========================================
  Files          95       95              
  Lines       23062    23057       -5     
==========================================
- Hits        18586    18585       -1     
+ Misses       4476     4472       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sunshowers sunshowers deleted the clear-job-object branch December 17, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant