[nextest-runner] use grace period on receiving Windows Ctrl-C #1984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1984 +/- ##
==========================================
- Coverage 80.62% 80.62% -0.01%
==========================================
Files 95 95
Lines 23071 23094 +23
==========================================
+ Hits 18602 18620 +18
- Misses 4469 4474 +5 ☔ View full report in Codecov by Sentry. |
Previously on Windows, we would not do anything at all on receiving Ctrl-C, letting tests exit on their own. With this change, in case of Ctrl-C, nextest will apply the same grace period that it does on Unix. By default, nextest will now wait 10 seconds before calling `TerminateJobObject` on the test. Like on Unix, a double Ctrl-C will kill the test immediately. The behavior in case of timeouts is unchanged -- call `TerminateJobObject` immediately.
sunshowers
force-pushed
the
ctrl-c-terminate
branch
4 times, most recently
from
24ce512 to
c1abd3f
Compare
While cancelling a run, it was previously possible for new units to be registered. Make it so that the receiver returns None in this case.
Gives the dispatcher a chance to control communication.
sunshowers
force-pushed
the
ctrl-c-terminate
branch
from
c1abd3f to
c433be1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously on Windows, we would not do anything at all on receiving Ctrl-C, letting tests exit on their own.
With this change, in case of Ctrl-C, nextest will apply the same grace period that it does on Unix. By default, nextest will now wait 10 seconds before calling
TerminateJobObjecton the test. Like on Unix, a double Ctrl-C will kill the test immediately.The behavior in case of timeouts is unchanged -- call
TerminateJobObjectimmediately.This PR also has a few more fixes to Windows display, and to cancellation on all platforms.