runner improvements and signal bugfixes #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help test out various state changes to the context.
It was always the intention to do this, but this broke at some point :( Unbreak it and add tests.
Previously we'd use the same task for all tests -- that turns out to be fine in most cases, but doesn't quite provide per-test isolation, and is slower in repos like clap that have lots of small tests. Switch to using the same task instead. It's cool that async-scoped kind of works here, but non-static tasks are such a pain to work with in general. This makes the clap tests significantly faster. On `fc55ad08`, runtime on my desktop (Ryzen 7950X/Linux) goes from 0.36 seconds to 0.24.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1972 +/- ##
==========================================
- Coverage 80.38% 80.23% -0.16%
==========================================
Files 92 92
Lines 22697 22745 +48
==========================================
+ Hits 18246 18250 +4
- Misses 4451 4495 +44 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.