[nextest-runner] move some code around #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Going to start moving code out of this into separate modules in upcoming commits.
This is part of the external interface, so it should live in `reporter/events.rs`.
Part of the external interface.
Reporter event types are special and numerous, and for ease of understanding it is easier to put them into their own module.
More thinning out of `runner/imp.rs`.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1947 +/- ##
==========================================
- Coverage 79.97% 79.97% -0.01%
==========================================
Files 84 86 +2
Lines 22208 22217 +9
==========================================
+ Hits 17760 17767 +7
- Misses 4448 4450 +2 ☔ View full report in Codecov by Sentry. |
…nts.rs Even more thinning out of `runner/imp.rs`.
…Status Simplify this part of the code a bit.
Add `runner/internal_events.rs`, and move some types into this module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional changes in this code -- this is pure code movement.