even more prep work #1931
Merged
even more prep work #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Status Carrying around a second parameter doesn't seem very useful.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1931 +/- ##
==========================================
+ Coverage 80.00% 80.16% +0.16%
==========================================
Files 81 82 +1
Lines 21086 21144 +58
==========================================
+ Hits 16869 16950 +81
+ Misses 4217 4194 -23 ☔ View full report in Codecov by Sentry. |
I realized that we need a central way to identify and manage all the different ways in which a test or script can error out. Add a `UnitErrorDescription` struct which is responsible for all this management.
sunshowers
force-pushed
the
child-errors-2
branch
from
0dd02e5 to
f8f98d3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite happy with the child error management refactor.