a few more preparatory improvements #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're going to add a conditional signal to this list in the future, and it's easier to just do this.
This was (a) incorrect (should have included paused time) and (b) not resilient to clock changes.
sunshowers
force-pushed
the
sleep-improvements
branch
from
93f5118 to
dc77eea
Compare
1. In `poll`, unconditionally call `this.sleep.poll`. The rationale is in the attached comment. 2. Fix `reset_original_duration` to work correctly with paused timers, and rename it to `reset_last_duration`. 3. Add `reset` to reset to a given duration.
sunshowers
force-pushed
the
sleep-improvements
branch
from
dc77eea to
4885cae
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1913 +/- ##
=========================================
+ Coverage 0 79.68% +79.68%
=========================================
Files 0 81 +81
Lines 0 20747 +20747
=========================================
+ Hits 0 16532 +16532
- Misses 0 4215 +4215 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.