Fix default-config.toml comment on retry semantics
#1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Did I understand wrong that after a retry if the test succeeds is marked as flakey? If so, should the text in the default-config.toml be as suggested by this PR?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1174 +/- ##
==========================================
+ Coverage 78.07% 78.08% +0.01%
==========================================
Files 69 69
Lines 17446 17446
==========================================
+ Hits 13621 13623 +2
+ Misses 3825 3823 -2 ☔ View full report in Codecov by Sentry. |
|
Yes, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Did I understand wrong that after a retry if the test succeeds is marked as flakey?
If so, should the text in the default-config.toml be as suggested by this PR?