Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use bare minimum chrono features #1073

Merged
merged 2 commits into from
Oct 27, 2023

Conversation

littledivy
Copy link
Contributor

@littledivy littledivy commented Oct 27, 2023

Hey, we are using quick-junit in Deno. I'm trying to get rid of dynamic library that cost startup time. It turns out chrono's "clock" features pulls in iana-time-zone which pulls in the core-foundation on macOS.

This PR just disables the default features (including "clock") in chrono, no functional changes.

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #1073 (2b65899) into main (beed18c) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1073   +/-   ##
=======================================
  Coverage   79.13%   79.13%           
=======================================
  Files          64       64           
  Lines       16555    16555           
=======================================
  Hits        13100    13100           
  Misses       3455     3455           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sunshowers
Copy link
Member

Thank you!

@sunshowers sunshowers merged commit 0fd55ed into nextest-rs:main Oct 27, 2023
13 checks passed
@sunshowers
Copy link
Member

Released in quick-junit 0.3.5.

@littledivy littledivy deleted the chrono_features branch October 28, 2023 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants