Handle LoginException when authenticating with Apache #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"handleApacheAuth()" can throw a LoginException when trying to authenticate as a disabled user. This needs to be explicitly handled to redirect to an error page, as otherwise the login page will try to be loaded which, in turn, will try to authenticate again and cause an endless loop. Signed-off-by: Daniel Calviño Sánchez <[email protected]>
blizzz
reviewed
Nov 27, 2024
| @@ -4,6 +4,7 @@ | |||
| * SPDX-License-Identifier: AGPL-3.0-or-later | |||
| */ | |||
|
|
|||
| use OC\User\LoginException; | |||
There was a problem hiding this comment.
I think there should be a fitting Exception or interface in the OCP space, no?
There was a problem hiding this comment.
Signed-off-by: Daniel Calviño Sánchez <[email protected]>
blizzz
approved these changes
Dec 3, 2024
blizzz
deleted the
handle-loginexception-when-authenticating-with-apache
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#549 might be fixed by this, although I am not sure if the problem can happen too when using SAML 2.0 or only when authenticating via environment variable (this pull request only fixes it when authenticating via environment variable).
handleApacheAuth()can throw aLoginExceptionwhen trying to authenticate as a disabled user (and it has done it since Nextcloud 23.0.0, 22.2.1, 21.0.6 and 20.0.14). This needs to be explicitly handled to redirect to an error page, as otherwise the login page will try to be loaded which, in turn, will try to authenticate again and cause an endless loop.How to test
Result with this pull request
An error page with Account disabled is shown
Result without this pull request
Infinite loop of redirections