Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): cleanup composer #909

Merged
merged 1 commit into from
Nov 26, 2024
Merged

build(deps): cleanup composer #909

merged 1 commit into from
Nov 26, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented Nov 25, 2024

  • reduce from two composer files to one
  • thus removed 3rdparty dir
  • thus not commit vendor files anymore

This make the app more streamlined with others. Also, updated to 3rdparty needed manually committing vendors and last time the test did not catch it. So why bother. Smaller, simpler, better.

- reduce from two composer files to one
- thus removed 3rdparty dir
- thus not commit vendor files anymore

Signed-off-by: Arthur Schiwon <[email protected]>
@blizzz blizzz added 3. to review dependencies Pull requests that update a dependency file labels Nov 25, 2024
@blizzz
Copy link
Member Author

blizzz commented Nov 26, 2024

tests unrelated

@blizzz blizzz merged commit 4368a73 into master Nov 26, 2024
50 of 52 checks passed
@blizzz blizzz deleted the fix/noid/composer-cleanup branch November 26, 2024 09:37
@shk3bq4d
Copy link

shk3bq4d commented Dec 6, 2024

Hello,

I have a multi-year instance of nextcloud and have been running user_saml for multiple years.

I am not sure if I am doing anything wrong, anyhow user_saml stopped working when moving from 6.3.0 to 6.4.1 while I was upgrading nextcloud 29.0.9 to 29.0.10.

Not sure if this is intended so I won't open an issue and will stick to 6.3.0 for the time being.

{
    "reqId": "U3BCpkul9LDUMQz7vPjd",
    "level": 3,
    "time": "2024-12-06T10:25:01+00:00",
    "remoteAddr": "",
    "user": "--",
    "app": "no app in context",
    "method": "",
    "url": "--",
    "message": "App user_saml threw an error during app.php load: Failed opening required '/var/www/html/custom_apps/user_saml/appinfo/../vendor/autoload.php' (include_path='/var/www/html/3rdparty/pear/archive_tar:/var/www/html/3rdparty/pear/console_getopt:/var/www/html/3rdparty/pear/pear-core-minimal/src:/var/www/html/3rdparty/pear/pear_exception:/var/www/html/apps:/var/www/html/custom_apps')",
    "userAgent": "--",
    "version": "29.0.10.1",
    "exception": {
        "Exception": "Error",
        "Message": "Failed opening required '/var/www/html/custom_apps/user_saml/appinfo/../vendor/autoload.php' (include_path='/var/www/html/3rdparty/pear/archive_tar:/var/www/html/3rdparty/pear/console_getopt:/var/www/html/3rdparty/pear/pear-core-minimal/src:/var/www/html/3rdparty/pear/pear_exception:/var/www/html/apps:/var/www/html/custom_apps')",
        "Code": 0,
        "Trace": [
            {
                "file": "/var/www/html/lib/private/App/AppManager.php",
                "line": 525,
                "function": "require_once"
            },
            {
                "file": "/var/www/html/lib/private/App/AppManager.php",
                "line": 416,
                "function": "requireAppFile",
                "class": "OC\\App\\AppManager",
                "type": "::",
                "args": [
                    "/var/www/html/custom_apps/user_saml"
                ]
            },
            {
                "file": "/var/www/html/lib/private/App/AppManager.php",
                "line": 216,
                "function": "loadApp",
                "class": "OC\\App\\AppManager",
                "type": "->",
                "args": [
                    "user_saml"
                ]
            },
            {
                "file": "/var/www/html/cron.php",
                "line": 78,
                "function": "loadApps",
                "class": "OC\\App\\AppManager",
                "type": "->",
                "args": []
            }
        ],
        "File": "/var/www/html/custom_apps/user_saml/appinfo/app.php",
        "Line": 14,
        "message": "App user_saml threw an error during app.php load: Failed opening required '/var/www/html/custom_apps/user_saml/appinfo/../vendor/autoload.php' (include_path='/var/www/html/3rdparty/pear/archive_tar:/var/www/html/3rdparty/pear/console_getopt:/var/www/html/3rdparty/pear/pear-core-minimal/src:/var/www/html/3rdparty/pear/pear_exception:/var/www/html/apps:/var/www/html/custom_apps')",
        "exception": {},
        "CustomMessage": "App user_saml threw an error during app.php load: Failed opening required '/var/www/html/custom_apps/user_saml/appinfo/../vendor/autoload.php' (include_path='/var/www/html/3rdparty/pear/archive_tar:/var/www/html/3rdparty/pear/console_getopt:/var/www/html/3rdparty/pear/pear-core-minimal/src:/var/www/html/3rdparty/pear/pear_exception:/var/www/html/apps:/var/www/html/custom_apps')"
    }
}

@blizzz
Copy link
Member Author

blizzz commented Dec 6, 2024

if you fetch it from git, you have to run "composer install" now

@shk3bq4d
Copy link

shk3bq4d commented Dec 6, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants