-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enh(integrity): do not expect ocm-provider anymore #506
base: master
Are you sure you want to change the base?
Conversation
test needs updates… the stable ones fail of course. |
I removed now all non-master tests… |
This comment was marked as resolved.
This comment was marked as resolved.
ba6e3ac
to
b10ed0d
Compare
Signed-off-by: Arthur Schiwon <[email protected]>
Signed-off-by: Arthur Schiwon <[email protected]>
0aa8187
to
bd9e433
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are you removing all tests?
I am removing tests against NC 24 to 26, because they are failing due to presence of the This updater branch runs in reality on 28 only, therefore the tests against the old versions were already suspicious and may give you a wrong picture of both expectations and results. |
But these tests are testing the updater in several scenarios, such as beta versions, minor versions, wrong signature, and so on and so on. If you merge this the only test remaining is updating from master branch to master branch which only happens on developer setups and none of the productions scenarios are tested anymore. |
The
ocm-provider
dir was removed in 26.0.8 and 27.1.2.