-
-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add permanent warning when notifications are not set up correctly #4476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/backport to stable-20.0 |
mahibi
requested review from
rapterjet2004,
sowjanyakch,
nickvergessen and
Antreesy
November 22, 2024 16:41
This comment was marked as outdated.
This comment was marked as outdated.
mahibi
added
2. developing
Work in progress
and removed
3. to review
Waiting for reviews
labels
Nov 25, 2024
mahibi
force-pushed
the
featue/noid/addIgnoreBatteryOptimizationHint
branch
from
November 25, 2024 23:05
f392cac
to
096b361
Compare
This comment was marked as outdated.
This comment was marked as outdated.
mahibi
changed the title
Add permanent hint when battery optimization is not ignored
Add permanent warning when notifications are not set up correctly
Nov 26, 2024
mahibi
added
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
labels
Nov 26, 2024
rapterjet2004
approved these changes
Nov 26, 2024
sowjanyakch
approved these changes
Nov 26, 2024
Also add an option to not show the hint, when user doesn't want to ignore battery optimization. Only show these features when gplay services are available. Otherwise don't show them as it would pretend notifications would be possible without gplay. Signed-off-by: Marcel Hibbe <[email protected]>
…on is enabled Open notification settings when click on warning Also, still offer to enable notifications and disable battery optimization on first install Signed-off-by: Marcel Hibbe <[email protected]>
…log for asking direct permission was not shown by android Signed-off-by: Marcel Hibbe <[email protected]>
… is is not permitted. Otherwise user can't enable them anyway Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
mahibi
force-pushed
the
featue/noid/addIgnoreBatteryOptimizationHint
branch
from
November 26, 2024 14:25
7a9c281
to
6dc52fe
Compare
nickvergessen
approved these changes
Nov 26, 2024
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4476-talk.apk |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Show a warning whenever something regarding notifications is not set up correctly.
known bug is #4484 (won't be fixed for now if no one comes up with an idea..)
🖼️ Screenshots/ Videos
Warning when notifications are not set up correctly
notAllowAllPermissionsOnStart.mp4
allowAllPermissionsOnStart.mp4
🏁 Checklist
/backport to stable-xx.x