Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump minSdkVersion to 26 and remove old checks #4470

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Conversation

sowjanyakch
Copy link
Contributor

@sowjanyakch sowjanyakch commented Nov 20, 2024

Resolve #4369

🚧 TODO

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94157
Errors13281

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7474
Internationalization33
Malicious code vulnerability33
Performance55
Security11
Total108108

Lint increased!

@sowjanyakch sowjanyakch marked this pull request as ready for review November 20, 2024 16:00
@sowjanyakch sowjanyakch self-assigned this Nov 20, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 20, 2024
@mahibi
Copy link
Collaborator

mahibi commented Nov 21, 2024

added 2 minor commits.

documentation PRs:

nextcloud/spreed#13827
nextcloud/documentation#12385

@mahibi mahibi added this to the 20.1.0 milestone Nov 21, 2024
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4470-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi merged commit 3f5937d into master Nov 21, 2024
13 of 16 checks passed
@mahibi mahibi deleted the bump_minSdkVersion branch November 21, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bump minSdkVersion to 26 (Android 8.0)
2 participants