Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Rxjava to Coroutines #4455

Merged
merged 12 commits into from
Nov 19, 2024
Merged

Migrate Rxjava to Coroutines #4455

merged 12 commits into from
Nov 19, 2024

Conversation

sowjanyakch
Copy link
Contributor

Resolve #4412

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@sowjanyakch sowjanyakch marked this pull request as ready for review November 15, 2024 17:08
@sowjanyakch sowjanyakch self-assigned this Nov 15, 2024
@sowjanyakch sowjanyakch added the 3. to review Waiting for reviews label Nov 15, 2024
@mahibi
Copy link
Collaborator

mahibi commented Nov 18, 2024

just needs to be rebased on master & conflicts must be resolved

Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings94154
Errors13281

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7474
Internationalization33
Malicious code vulnerability33
Performance55
Security11
Total108108

Lint increased!

Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4455-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@sowjanyakch sowjanyakch merged commit 8228f77 into master Nov 19, 2024
15 of 17 checks passed
@sowjanyakch sowjanyakch deleted the coroutine_3 branch November 19, 2024 10:22
@mahibi mahibi added this to the 20.1.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate some RxJava to coroutines #3
2 participants