Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/4378/add temporary messages while sending #4422

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Nov 6, 2024

resolve #4378

WIP

πŸ–ΌοΈ Screenshots

🏚️ Before 🏑 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • πŸ”– Capability is checked or not needed
  • πŸ”™ Backport requests are created or not needed: /backport to stable-xx.x
  • πŸ“… Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@mahibi mahibi force-pushed the feature/4378/addTemporaryMessagesWhileSending branch from d335f4f to 17995ee Compare November 21, 2024 21:45
@mahibi mahibi force-pushed the feature/4378/addTemporaryMessagesWhileSending branch 2 times, most recently from ddf5898 to fea6de6 Compare December 3, 2024 09:42
Copy link
Contributor

github-actions bot commented Dec 3, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4422-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

(as datasources should be only used in repositories)

use coroutines instead RxJava for api calls triggered by MessageInputViewModel

Signed-off-by: Marcel Hibbe <[email protected]>
Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi force-pushed the feature/4378/addTemporaryMessagesWhileSending branch from fea6de6 to 43335b2 Compare December 3, 2024 13:37
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Codacy

Lint

TypemasterPR
Warnings158158
Errors7373

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

Copy link
Contributor

github-actions bot commented Dec 3, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4422-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show pending indicator for messages that are being sent (incl retry)
1 participant