Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix to scroll to last read message #4141

Merged

Conversation

mahibi
Copy link
Collaborator

@mahibi mahibi commented Sep 4, 2024

manual backport of #4136
replaces #4137

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

This will fix to scroll to the last read message when a chat is opened.

Some refactorings were made that are not necessary for the fix (I tried to also show the "Unread messages" hint in the adapter but came to the conclusion this is not a good idea until chatkit is removed. Chatkit doesn't support to add some item in between but only at the end or start which will make it too complicated..)

Signed-off-by: Marcel Hibbe <[email protected]>
@mahibi mahibi added this to the 20.0.0 milestone Sep 4, 2024
@mahibi mahibi self-assigned this Sep 4, 2024
@mahibi mahibi merged commit fbf7bc4 into stable-20.0 Sep 4, 2024
10 of 16 checks passed
@mahibi mahibi deleted the backport/4137/fixUnreadMessageScrollOnEnterChat branch September 4, 2024 13:33
Copy link
Contributor

github-actions bot commented Sep 4, 2024

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4141-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant