Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes share link #4129

Closed
wants to merge 1 commit into from
Closed

fixes share link #4129

wants to merge 1 commit into from

Conversation

RamReso
Copy link

@RamReso RamReso commented Aug 30, 2024

Resolves #4010

The problem was:

  • when sharing a link with nextcloud talk the link disappears.

General Observations:

  • Depending on the Type that is shared with nextcloud talk the behavior of the app differs:
    • e.g. when sharing a text it is copied into the sharedText in ConversationsListActivity which then opens the chatActivity which then opens MessageInputFragment, where then the sharedText is set into the binding.fragmentMessageInputView.inputEditText, but then not send.
    • when sharing a photo showSendFilesConfirmDialog gets called in ConversationsListActivity which then uploads the photo

How it is fixed

  • just send the message with the sharedText in MessageInputFragment

Problems with the fix

  • there is no confirmation dialog, if one really wants to share a link with a certain chat (which could be bad for a person like me, that likes to accidentally press the wrong chat)
  • it is not possible to share a link without notification

🚧 TODO

  • get some feedback

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

Signed-off-by: Noah Markert <[email protected]>
@mahibi
Copy link
Collaborator

mahibi commented Sep 4, 2024

Thank you @RamReso

The expected behavior is that the shared text is just pasted into the textfield, so it's possible to edit it and there is no need for a confirm dialog.

The main problem here was that the shared text was set into the textfield, but it was immediately overwritten with "" in the restoreState method.

I created the PR #4139 which should fix it.

I will close your PR but thanks again to have a look!

@mahibi mahibi closed this Sep 4, 2024
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link from Android phone is not transferred to talk
3 participants